----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125284/#review85585 -----------------------------------------------------------
+1 This will save a lot of patch rebasing :D (i'm assuming every distro renames the file) - Hrvoje Senjan On Sept. 17, 2015, 11:32 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125284/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2015, 11:32 a.m.) > > > Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex > Dieter. > > > Repository: kservice > > > Description > ------- > > To not conflict with kde4runtime nor gnome nor xfce, distributions may > choose to have a different name for their applications.menu file. > To enable this without pitchy patching make the installed name fully > parameterized via the cmake variable APPLICATIONS_MENU_NAME. > > This is based on the debian/kubuntu patch to rename the file: > http://anonscm.debian.org/cgit/pkg-kde/frameworks/kservice.git/tree/debian/patches/kubuntu_rename-application-menu-file.diff?h=kubuntu_wily_archive&id=de26b631f641b0aa5e2e184443ff6970ed5e8b56 > > > Diffs > ----- > > CMakeLists.txt 958db4a4891a982b7e9a1bd5c903cb4d126e1cdc > src/CMakeLists.txt 5ea5b002411a098a0111a6ee552c554ec461cc28 > src/sycoca/kbuildsycoca.cpp 60a60662ac014ddc73825ca40f604730e0596537 > > Diff: https://git.reviewboard.kde.org/r/125284/diff/ > > > Testing > ------- > > clean cmake && make && make install > > -- Installing: ./etc/xdg/menus/applications.menu > > changed cached var && make && make install > > -- Installing: ./etc/xdg/menus/kf5-applications.menu > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
