----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125272/#review85530 -----------------------------------------------------------
+1 - Aleix Pol Gonzalez On Sept. 17, 2015, 12:04 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125272/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2015, 12:04 a.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > ------- > > This tests what happens now in applications, in order to catch any possible > issues with the in-process rebuild. > On the other hand, I left the QProcess usage in ksycocatest, so that this > one ensures the kbuildsycoca5 binary still works. > > This change caught a nasty code path where the sycoca-header-check > during rebuild would actually trigger a rebuild, which would deadlock > on the lockfile. This bug was already in 5.14.0 but there the symptom > was harder to spot due to the process separation (constant rebuild, bug > 352787). > > > Diffs > ----- > > autotests/kmimeassociationstest.cpp > 5550938abe4d9c9c1ee698ac1b225312690e4aa6 > autotests/kservicetest.cpp ffd963dfc99fb52ce9c8546defc7148c1a982858 > autotests/ksycocadicttest.cpp 52ce426fe2a0020f1952389420493f3ff6f32092 > autotests/ksycocathreadtest.cpp 29a096fea2b1d315a4ca13e241a383d410fd157a > src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 > > Diff: https://git.reviewboard.kde.org/r/125272/diff/ > > > Testing > ------- > > unittests > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
