----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125212/#review85323 -----------------------------------------------------------
autotests/kservicetest.cpp (line 270) <https://git.reviewboard.kde.org/r/125212/#comment58957> QSignalSpy::wait is even better ;) (instead of polling it just connects to the signal and starts a timer for timeout) - David Faure On Sept. 13, 2015, 4:25 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125212/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2015, 4:25 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > ------- > > i.e. remove double-spying on the same signal, within runKBuildSycoca() > and in the caller of runKBuildSycoca(). > Only kept the one within runKBuildSycoca(). > > > Diffs > ----- > > autotests/kservicetest.cpp afaf20d33c31f83036ecba4f65e8f0073bf015df > > Diff: https://git.reviewboard.kde.org/r/125212/diff/ > > > Testing > ------- > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
