----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124876/#review84583 -----------------------------------------------------------
src/sycoca/ksycoca.cpp (line 574) <https://git.reviewboard.kde.org/r/124876/#comment58543> Does the added `(void)` disable some kind of warning? src/sycoca/ksycoca.cpp (line 592) <https://git.reviewboard.kde.org/r/124876/#comment58544> random thought: Is the return value given by kbuildsyscoca useful? - Vishesh Handa On Aug. 28, 2015, 9:41 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124876/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 9:41 a.m.) > > > Review request for KDE Frameworks, Boudewijn Rempt and Vishesh Handa. > > > Repository: kservice > > > Description > ------- > > If 1.5s have passed since the last time we checked, we compare the mtime of > the directories (12 dirs on my system) with the timestamp stored in the > ksycoca database (which indicates that all changes prior to that time > are in the DB). > > Note that we only check the mtime of dirs, not files. Therefore manually > editing an installed .desktop file will require touching the dir, or > running kbuildsycoca5. > > > Diffs > ----- > > src/sycoca/ksycoca.cpp b7f7abc88db90d784851d91036069e0647fdcbf6 > src/sycoca/ksycoca_p.h 9f403d6f4be2b406f4985f668176cfa56a5898ea > > Diff: https://git.reviewboard.kde.org/r/124876/diff/ > > > Testing > ------- > > the kservice unittests still pass > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
