----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review84525 -----------------------------------------------------------
src/knewpasswordwidget.h (line 179) <https://git.reviewboard.kde.org/r/124963/#comment58492> s/strenght/strength/ src/knewpasswordwidget.h (line 185) <https://git.reviewboard.kde.org/r/124963/#comment58493> s/has/returns/ src/knewpasswordwidget.cpp (line 35) <https://git.reviewboard.kde.org/r/124963/#comment58494> Also initialize passwordStatus and toggleEchoModeAction variables here. src/knewpasswordwidget.cpp (line 63) <https://git.reviewboard.kde.org/r/124963/#comment58495> i18n instead of tr. You can also use ritch text mode here: http://doc.qt.io/qt-5.4/richtext-html-subset.html src/knewpasswordwidget.cpp (line 75) <https://git.reviewboard.kde.org/r/124963/#comment58496> i18n instead of tr src/knewpasswordwidget.cpp (line 92) <https://git.reviewboard.kde.org/r/124963/#comment58497> Is there any documentation explaining this calculation? src/knewpasswordwidget.cpp (line 124) <https://git.reviewboard.kde.org/r/124963/#comment58498> Code style: join this line with the next one. src/knewpasswordwidget.cpp (line 154) <https://git.reviewboard.kde.org/r/124963/#comment58499> Please write a short explanation of what is happening here. By what I could understand you are calculating the number of characters with different categories in the password, am I correct? src/knewpasswordwidget.cpp (line 202) <https://git.reviewboard.kde.org/r/124963/#comment58500> Before emitting this signal check if parameter status is different from passwordStatus. Do not emit the signal if they are equal. src/knewpasswordwidget.cpp (line 275) <https://git.reviewboard.kde.org/r/124963/#comment58503> If maxLength is less than minimumPasswordLength the user will not be able to type a valid password. Should not you check for that here and use minimumPasswordLength instead of maxLength in that particular case? - Lamarque Souza On Aug. 28, 2015, 9:24 a.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124963/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 9:24 a.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > This widget is a stripped-down version of KNewPasswordDialog, without any > dialog-specific stuff. > > ### Why a new widget? > > This widget is meant to be easily embedded in any custom password dialog, > including KNewPasswordDialog. It's the least common denominator of features > that any password dialog should offer to the user. > > ### Features > > * Password visibility action (same as RR 124698). The password verification > field is hidden if the user shows the password. > * Background warning colour. The password verification field gets a coloured > background whenever the password and its verification don't match. (feature > borrowed from Keepass) > * Password status signal. This allows the upper level dialogs to update their > stuff (enable/disable OK button, show warnings for low password strength, > etc.) > * Password strength bar can be hidden. > * Unit test. > > ### Use cases > At least the following: > > * Ark (new archive dialog) > * KNewPasswordDialog refactoring (my next RR if this one gets accepted) > > > Diffs > ----- > > autotests/CMakeLists.txt ac708ef33e3be89db85d43911f96e536c52f741d > autotests/knewpasswordwidgettest.h PRE-CREATION > autotests/knewpasswordwidgettest.cpp PRE-CREATION > src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 > src/knewpasswordwidget.h PRE-CREATION > src/knewpasswordwidget.cpp PRE-CREATION > src/knewpasswordwidget.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124963/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > knewpasswordwidget1.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/5796469c-28b7-4151-b9cb-6a327631db75__knewpasswordwidget1.png > knewpasswordwidget2.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/b3bfc9ac-ab8e-404c-8091-b5ad9e3e054f__knewpasswordwidget2.png > knewpasswordwidget3.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/dfaeea4e-65da-4961-b266-986a21f54ca7__knewpasswordwidget3.png > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
