----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124856/ -----------------------------------------------------------
(Updated ago. 21, 2015, 4:06 p.m.) Review request for KDE Frameworks and Thiago Macieira. Summary (updated) ----------------- Call newInstance from the child on first invocation Repository: kdelibs4support Description (updated) ------- For the first invocation, call newInstance ourselves instead of relying on the parent process to do it. With the new threading patches in qt dbus the current code races as the parent may end up calling newInstance before the child has set up the object that handles it. Diffs ----- src/kdeui/kuniqueapplication.cpp 713c6f4 src/kdeui/kuniqueapplication_p.h de4b328 Diff: https://git.reviewboard.kde.org/r/124856/diff/ Testing ------- konsole starts fine with this + Thiago's Qt dbus threading patches Thanks, Albert Astals Cid
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel