> On Aug. 19, 2015, 7:41 p.m., Albert Astals Cid wrote: > > I meant all the explicit, not only this one, by declaring it explicit we > > are changing the source compatibility, personally i'd reduce the patch to > > just the foreach const &
Ah, I see. So these warnings about explicit ctors are useless for libraries most of the time.. - Boris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124821/#review84068 ----------------------------------------------------------- On Aug. 19, 2015, 3:51 p.m., Boris Egorov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124821/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 3:51 p.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > ------- > > Fix krazy2 warnings (explicit ctors, foreach) > > > Diffs > ----- > > src/k7zip.cpp bdb2e5a > src/kar.h 85bd650 > src/karchive.h b528a4a > src/krcc.h 18c7d00 > src/kzip.h 84156c7 > > Diff: https://git.reviewboard.kde.org/r/124821/diff/ > > > Testing > ------- > > Build karchive, ktexteditor, kio. > > > Thanks, > > Boris Egorov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
