----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124746/#review84020 -----------------------------------------------------------
I'm still very surprised by the use case. How are you getting the full path to an application .desktop file without using the KService framework? It sounds like parsing all application desktop files by hand, which sounds horrible ;-) ... (and yes readMimeTypes() would be a better name if we end up deciding in favour of this; the desktop field is an historic misnaming, no point in propagating that to C++ developers) src/core/kdesktopfile.h (line 164) <https://git.reviewboard.kde.org/r/124746/#comment58202> Missing @since 5.14 - David Faure On Aug. 15, 2015, 5:38 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124746/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2015, 5:38 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > This allows to get the MimeType field of a desktop file to determin whether > eg. the given application would accept a given mime type. > > I'm not too happy about the name because "readMimeType" suggests it's a > single item but then it's consisteht with the key name. > > > Diffs > ----- > > src/core/kdesktopfile.cpp 254b59a > autotests/kdesktopfiletest.cpp 1a9c1c3 > src/core/kdesktopfile.h 2190051 > > Diff: https://git.reviewboard.kde.org/r/124746/diff/ > > > Testing > ------- > > Test passes > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
