----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124584/ -----------------------------------------------------------
Review request for KDE Frameworks and Martin Klapetek. Repository: knotifications Description ------- Introduce the use of qCDebug Diffs ----- src/CMakeLists.txt 13390f1 src/debug_p.h PRE-CREATION src/debug_p.cpp PRE-CREATION src/knotificationmanager.cpp 38bbc89 src/knotificationrestrictions.cpp 26acab6 src/knotifyconfig.cpp 2c8d33d src/kpassivepopup.cpp 60552b8 src/kstatusnotifieritem.cpp 8001050 src/kstatusnotifieritemdbus_p.cpp a9015c6 src/notifybyaudio.cpp 0fafdc7 src/notifybyexecute.cpp cde53e6 src/notifybylogfile.cpp ca3faf9 src/notifybypopup.cpp 932712d src/notifybytaskbar.cpp bbdf19d src/notifybytts.cpp ee73118 Diff: https://git.reviewboard.kde.org/r/124584/diff/ Testing ------- Compiled and run Kate/KWrite, no longer spam on the console like (at least not if not turned on again via config): kwrite(11559)/(default) KNotificationManager::notify: Calling notify on "Sound" kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::LoadingState to Phonon::StoppedState kwrite(11559)/(default) KNotificationManager::notify: Calling notify on "Taskbar" kwrite(11559)/(default) NotifyByTaskbar::notify: 0 75497555 kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::StoppedState to Phonon::LoadingState kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::LoadingState to Phonon::StoppedState kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::StoppedState to Phonon::LoadingState kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::LoadingState to Phonon::BufferingState kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::BufferingState to Phonon::PlayingState kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::PlayingState to Phonon::BufferingState kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::BufferingState to Phonon::PlayingState kwrite(11559)/(default) KNotificationManager::close: Closing notification 1 kwrite(11559)/(default) NotifyByPopupPrivate::closeGalagoNotification: not found dbus id to close 1 kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::PlayingState to Phonon::StoppedState Thanks, Christoph Cullmann
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
