----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124563/#review83274 -----------------------------------------------------------
Ship it! Very nice. Maybe KDevelop can finally provide a QtCreator-like shortcuts file ;) src/kshortcutsdialog.h (line 129) <https://git.reviewboard.kde.org/r/124563/#comment57504> Missing @since 5.13 for both new methods. - David Faure On July 31, 2015, 4:39 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124563/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 4:39 p.m.) > > > Review request for KDE Frameworks and Alexander Dymo. > > > Repository: kxmlgui > > > Description > ------- > > I wanted to make sure that it's possible to provide shortcut files easily. We > already had an export function but not an import one. > > * Instead of exporting all of the shortcuts into a directory full of xml > files, use KShortcutsEditor::exportConfiguration, that uses KConfig files. > * Add an action to import using KShortcutsEditor::importConfiguration. > > > Diffs > ----- > > src/kshortcutschemeseditor.cpp e9402bc > src/kshortcutsdialog.h 0e2bdaf > src/kshortcutsdialog.cpp 2c16b16 > src/kshortcutsdialog_p.h fb5007b > > Diff: https://git.reviewboard.kde.org/r/124563/diff/ > > > Testing > ------- > > Tests still pass. > I played around importing and exporting Kate shortcuts. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
