> On July 31, 2015, 5:19 p.m., David Faure wrote: > > src/CMakeLists.txt, line 20 > > <https://git.reviewboard.kde.org/r/124542/diff/1/?file=388805#file388805line20> > > > > I can't see how setting a variable to itself can possibly change > > anything, or make any sense (other than an extremely weird bug in cmake). > > > > Actually it could be that this interprets the string as a list or vice > > versa.... in which case the problem could be before this, at the time where > > this module sets CMAKE_MODULE_PATH (toplevel file?)
See my comment above. This change is correct. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124542/#review83249 ----------------------------------------------------------- On July 31, 2015, 7:34 a.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124542/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 7:34 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > BUG: 348061 > > > Diffs > ----- > > cmake/uriencode.cmake e5f3c3acd93d3871e44b6e6fb29ad7113e18d751 > src/CMakeLists.txt e3868fc4f22324d25f680c13609bfb92b8b7c41d > > Diff: https://git.reviewboard.kde.org/r/124542/diff/ > > > Testing > ------- > > Adding ':' to the list of escaped characters is probably not an ideal > solution, but let me hear your ideas. > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
