----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124505/#review83179 -----------------------------------------------------------
Ship it! lgtm src/kmultitabbar.cpp (line 238) <https://git.reviewboard.kde.org/r/124505/#comment57434> move up? - Milian Wolff On July 30, 2015, 11:11 a.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124505/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 11:11 a.m.) > > > Review request for KDE Frameworks and David Edmundson. > > > Repository: kwidgetsaddons > > > Description > ------- > > New API with QIcon parameters, deprecate the public API for QPixmap > > > Diffs > ----- > > src/kmultitabbar.h 11005a9 > src/kmultitabbar.cpp c289354 > src/kmultitabbar_p.h 958c9b8 > > Diff: https://git.reviewboard.kde.org/r/124505/diff/ > > > Testing > ------- > > Tested with Kate, seems to work OK ;=) > > The functions reuse the others, the constructors are duplicated. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
