----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124515/#review83132 -----------------------------------------------------------
Ship it! src/kcharselectdata.cpp (line 594) <https://git.reviewboard.kde.org/r/124515/#comment57409> Maybe add Q_ASSERT(categoryCode != 0), because if the file contains 0, the '--' will give 255 :-) - David Faure On July 29, 2015, 8:31 a.m., Rajeesh K Nambiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124515/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 8:31 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kwidgetsaddons > > > Description > ------- > > 1. Qt4 to Qt5 change introduced QChar::Category enum change (starting from 0 > instead of previous value 1). KCharSelectData::category() calculates integer > value from binary kcharselect-data and casts to QChar::Category and gets > confused, causing non-printable/control characters to be displayed. Fix this. > 2. Christoph Feck suggests to use QFontMetrics::boundingRect() instead of > width() for calculating column width. Fixes the Bengali Virama AU sign being > cut on the right side issue observed during testing. > > > Diffs > ----- > > src/kcharselect.cpp e988711 > src/kcharselectdata.cpp 5d89470 > > Diff: https://git.reviewboard.kde.org/r/124515/diff/ > > > Testing > ------- > > Tested Latin - basic, supplement-1, extended; South Asian - Bengali, > Malayalam. Works fine, see screenshots as well. > > > File Attachments > ---------------- > > KCharSelect-proper Unicode category > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/62ccf8d8-e442-491b-926e-3e5a4f14b12e__kcharselect-unicode-category.png > > > Thanks, > > Rajeesh K Nambiar > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
