----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124487/ -----------------------------------------------------------
(Updated July 28, 2015, 11:58 a.m.) Review request for KDE Frameworks and Valentin Rusu. Changes ------- I haven't noticed that there is already an error with code -42, so this updates the "unknown cipher or hash" to be -41 and adds a string representation too. But since frameworks are now in string freeze prior to the release, it's left as QStringLiteral for now and i18n will come after the release. Repository: kwallet Description ------- [theese will be separate commits] In the kwalletbackend.cc, all error codes are negative, I assume the "unknown cipher or hash" is also an error code and as such should be negative? When trying to open the backend in KWalletD::pamOpen, return the return code from the backend rather than -1. I'm not sure if there is perhaps an intent to always return -1 here though, but returning the actual return code seems more useful. Diffs (updated) ----- src/runtime/kwalletd/backend/kwalletbackend.cc 34e0419 src/runtime/kwalletd/kwalletd.cpp c40289a src/runtime/kwalletd/main.cpp 46ba2e6 Diff: https://git.reviewboard.kde.org/r/124487/diff/ Testing ------- Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
