----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124482/#review83021 -----------------------------------------------------------
Ship it! Long overdue, thanks A LOT! - Luigi Toscano On Lug. 27, 2015, 10:06 a.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124482/ > ----------------------------------------------------------- > > (Updated Lug. 27, 2015, 10:06 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > This produces a more helpful error when the user has Perl, but does not > have the Perl URI module installed. > > Note that we can't really avoid erroring out in the configure stage, since > perl is used while configuring KDocTools. > > > Diffs > ----- > > cmake/FindPerlModules.cmake PRE-CREATION > cmake/uriencode.cmake 6479c93fd0c43f4065cf2045eacf9d03e9c8b5d2 > > Diff: https://git.reviewboard.kde.org/r/124482/diff/ > > > Testing > ------- > > Without perl-uri installed, get the following error message: > > -- > > -- Could NOT find PerlModules_URI::Escape (missing: > PerlModules_URI_Escape_FOUND) > CMake Error at > /usr/share/cmake-3.2/Modules/FindPackageHandleStandardArgs.cmake:138 > (message): > Could NOT find PerlModules (missing: PerlModules_all_modules_found > URI::Escape) > Call Stack (most recent call first): > /usr/share/cmake-3.2/Modules/FindPackageHandleStandardArgs.cmake:374 > (_FPHSA_FAILURE_MESSAGE) > cmake/FindPerlModules.cmake:77 (find_package_handle_standard_args) > cmake/uriencode.cmake:34 (find_package) > src/CMakeLists.txt:4 (kdoctools_encode_uri) > > -- Configuring incomplete, errors occurred! > > With perl-uri installed, the REQUIRED packages found list includes: > > * PerlModules , <http://www.cpan.org> > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
