----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124372/ -----------------------------------------------------------
Review request for KDE Frameworks and Valentin Rusu. Repository: kwallet Description ------- When the DBus call in `invokeAndCheck()` fails when called from `MigrationAgent::isEmptyOldWallet()`, the code would crash because the `migrationAgent` global variable was not set (it's only set in `MigrationAgent::performMigration()`). Since global variables are evil ;-), this patch makes the `invokeAndCheck()` template to take the `MigrationAgent` instance pointer as an argument. Diffs ----- src/runtime/kwalletd/migrationagent.cpp a2a6498 Diff: https://git.reviewboard.kde.org/r/124372/diff/ Testing ------- Thanks, Daniel Vrátil
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
