> On July 15, 2015, 7:20 p.m., Kåre Särs wrote: > > I have been looking a bit at the frameworks integration just around that > > code sniplet and wondered why KDEPlatformFileDialogHelper::setDirectory() > > is called three times every time the file dialog is opened. And for remote > > protocols the last time would be wrong. I have not had the time to check :( > > > > I think we might a crash here if you use m_dialog->directory() of the just > > deleted m_dialog ;)
You are correct, thank you very much! I changed it from deleteLater at the last time. Will put the deleteLater back... - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124364/#review82549 ----------------------------------------------------------- On July 15, 2015, 5:29 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124364/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 5:29 p.m.) > > > Review request for KDE Frameworks and Leszek Lesner. > > > Repository: frameworkintegration > > > Description > ------- > > Even though it's the correct thing to do. Its value used to be overriden at > some point and it was only fixed for 5.5 [1]. > > [1] https://codereview.qt-project.org/#/c/105246/ > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 02aa56e > > Diff: https://git.reviewboard.kde.org/r/124364/diff/ > > > Testing > ------- > > Fixed it on a broken installation. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
