> On July 9, 2015, 12:02 p.m., Aleix Pol Gonzalez wrote:
> > What's the use case?
>
> Elvis Angelaccio wrote:
> Basically more user-friendly messages for the users.
> See RR 120204 and in particular this screenshot:
> https://git.reviewboard.kde.org/r/120204/file/2145/
Why don't you use QMimeDatabase().mimeTypeForName("application/...").name()?
In fact, the filter could be `"Any file (*)"` and then it wouldn't be too
useful, you're referring to the file's mimetype anyway.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124303/#review82253
-----------------------------------------------------------
On July 9, 2015, 11:47 a.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124303/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 11:47 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> This patch implements the `KFileWidget::currentFilterText()` function.
> This is simply the `currentText()` of the `KFileFilterCombo` widget, i.e. the
> actual filter text displayed to the user.
>
>
> Diffs
> -----
>
> src/filewidgets/kfilewidget.h 5b59ea9a57f38da3cb0e94da509d3943ff5a672e
> src/filewidgets/kfilewidget.cpp dc3c1f49a2e7b50abd409231436af9da414a24fd
>
> Diff: https://git.reviewboard.kde.org/r/124303/diff/
>
>
> Testing
> -------
>
> I compiled and installed KIO, then I called the new function from Ark
> frameworks branch. Works as expected.
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
