> On June 30, 2015, 12:07 p.m., Kai Uwe Broulik wrote: > > src/gui/kstandardshortcut.h, line 372 > > <https://git.reviewboard.kde.org/r/124213/diff/1/?file=381769#file381769line372> > > > > Isn't Ctrl+Tab usually next tab? > > Aleix Pol Gonzalez wrote: > Here, Konsole uses shift+arrow to change tab. Also it doesn't use Ctrl+T.
Konsole is always a bit special because it has to leave Ctrl+<letter> shortcuts available for terminal apps running within konsole. And on the other hand it doesn't have lineedits, so it can use shift+arrow while apps with lineedits can't. So Konsole is probably not a good example to use for the general case. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124213/#review81896 ----------------------------------------------------------- On June 30, 2015, 9:13 a.m., Simon Persson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124213/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 9:13 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > QKeySequence already has AddTab as a standard shortcut, but it was missing in > KStandardShortcut. Main problem with this is that users could not configure > the shortcut globally. This is of course only a first step, applications > would have to be updated to use this also. > Since QKeySequence uses Ctrl+Shift+N and Ctrl+T for this action when running > on KDE, this patch just goes with that as the chosen default. > Also fixes documentation error for tabNext and tabPrev that I happened to > notice. > > > Diffs > ----- > > src/gui/kstandardshortcut.h 5bb07fb > src/gui/kstandardshortcut.cpp 8400737 > > Diff: https://git.reviewboard.kde.org/r/124213/diff/ > > > Testing > ------- > > Compiles, test suite ok. > > > Thanks, > > Simon Persson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
