> On June 30, 2015, 10:41 a.m., Martin Gräßlin wrote: > > ping applications maintainers: please also consider whether version should > > be first tab or whether about should stay first tab. > > Albert Astals Cid wrote: > If we are going to do this, "About" should be the first tab, after all > i'm getting to that dialog by doing "Help -> About Application", why would i > get something different than About? But i'm still unsure what's the benefit > of moving the version number away from "About". If it is space concerns on > the "title" area, maybe we can move it to the content area as you're doing > but not to a different tab and just in the "About" tab?
depending on which application the about tab can be quite crowded already. And I want to give applications in a follow up patch the chance to insert more version information (e.g. libFoo x.y.z, libBar z.y.x) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124133/#review81885 ----------------------------------------------------------- On June 20, 2015, 6:30 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124133/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 6:30 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > This replaces the version information of the version and frameworks and > moves it into a dedicated tab. In this tab the information is extended > by the Qt version (which is equally relevant as e.g. the frameworks > version) in both runtime and compile time. > > Also windowing system is added. This will become a useful information > for KWin developers starting in Plasma 5.4 when users start to test > things out and we need to know whether the window they experience the > problem with is running on wayland or xwayland. > > > Diffs > ----- > > src/kaboutapplicationdialog.cpp 5eeea7711aa4f95a9cd4191d68ad330ef795caea > > Diff: https://git.reviewboard.kde.org/r/124133/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > New wayland, new X11, old X11 > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/20/b76ba6ae-b01c-4c6a-9248-29d39c652d83__snapshot_J11265.png > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
