----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124143/#review81720 -----------------------------------------------------------
Ship it! src/personssortfilterproxymodel.h (line 42) <https://git.reviewboard.kde.org/r/124143/#comment56040> "...that should be specified in..." reads a bit strange, "should be present" seems a better fit src/personssortfilterproxymodel.h (line 49) <https://git.reviewboard.kde.org/r/124143/#comment56038> const QStringList& props -> const QStringList &props src/personssortfilterproxymodel.cpp (line 22) <https://git.reviewboard.kde.org/r/124143/#comment56039> This is unused - Martin Klapetek On June 22, 2015, 7:47 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124143/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 7:47 a.m.) > > > Review request for KDE Frameworks, KDEPIM and Martin Klapetek. > > > Repository: kpeople > > > Description > ------- > > Makes it possible to filter the model by the offered properties. > > > Diffs > ----- > > src/CMakeLists.txt e050b8d > src/backends/abstractcontact.h 69e6b6d > src/backends/abstractcontact.cpp f5cd452 > src/personssortfilterproxymodel.h PRE-CREATION > src/personssortfilterproxymodel.cpp PRE-CREATION > autotests/CMakeLists.txt ece7e60 > autotests/fakecontactsource.h 53f1ef2 > autotests/fakecontactsource.cpp 2e12c2d > autotests/persondatatests.cpp f752e5d > autotests/personsmodeltest.cpp 8a467ef > autotests/personsproxymodeltest.h PRE-CREATION > autotests/personsproxymodeltest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124143/diff/ > > > Testing > ------- > > I ran the unit test until it passed. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
