----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124066/ -----------------------------------------------------------
Review request for KDE Frameworks, Alex Richardson and David Faure. Repository: kcoreaddons Description ------- This patch adds X-KDE-FormFactor to the keys recognized as stringlists. We would like to see this to go in to allow us to filter plugins (KCMs for example) by form factor, so we only display UI plugins that are suitable for a given target device. The idea is that plugins indicate which form factor (for example media center, tablet, desktop, etc...) they're suitable for, and the "host application" filters based on these. If this approach is deemed valid, I'd be happy to add convenience API to KPluginMetaData, i.e. QStringList KPluginMetaData::formFactor(). This patch would be the minimal implementation we'd need. The naming of the key is of course open to better suggestions. Diffs ----- autotests/data/fakeplugin.desktop 95152f6 autotests/kpluginmetadatatest.cpp 231ac36 src/lib/plugin/desktopfileparser.cpp b19da6b Diff: https://git.reviewboard.kde.org/r/124066/diff/ Testing ------- added autotest, also implemented using this in the Plasma Active settings app as proof-of-concept, works like a charm. Thanks, Sebastian Kügler
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
