----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124032/#review81277 -----------------------------------------------------------
The test doesn't check that user completion still works though? (in the case where it's expected, ~foo). I'm curious btw, why did it crash/assert? Finally I wonder why this didn't happen in kdelibs4, but ok, the code has had some changes due to the QUrl->KUrl porting, you don't *have* to answer this one ;) - David Faure On June 6, 2015, 8:58 p.m., Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124032/ > ----------------------------------------------------------- > > (Updated June 6, 2015, 8:58 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > BUG: 346920 > REVIEW: 124032 > > > Diffs > ----- > > autotests/kurlcompletiontest.cpp 55bd38011c93ea2d35a53a911a4878f28a09c00c > src/widgets/kurlcompletion.cpp d7ae787e6c3d1dba1a168e77cc2d5001b4bed7ef > > Diff: https://git.reviewboard.kde.org/r/124032/diff/ > > > Testing > ------- > > added a unit test, it now passes. also kate and the manual > kurlrequestertest_gui test don't crash anymore when I insert "~/." into a url > requester. > > > Thanks, > > Milian Wolff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
