----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123778/ -----------------------------------------------------------
(Updated May 27, 2015, 2:43 p.m.) Status ------ This change has been discarded. Review request for KDE Frameworks and Ivan Čukić. Repository: kactivities Description ------- If the DBus call ends with error, reportResult is not called in DBusCallFutureInterface and calling QFuture::result() without actually setting the result leads to crash. In case of error, continuation callback is not called (maybe it would be good to somehow indicate the error?). Diffs ----- src/utils/dbusfuture_p.h 336235c Diff: https://git.reviewboard.kde.org/r/123778/diff/ Testing ------- No longer crashes Thanks, David Rosca
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel