-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123791/
-----------------------------------------------------------

(Updated May 14, 2015, 3:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 15699daca3dd5d7fd48a94c1cbd4cfd280c46149 by Dan Vrátil to 
branch master.


Repository: kemoticons


Description
-------

Loading KEmoticonsTheme can be quite expensive (because of the IO when loading 
the theme), so for example switching between emails in KMail is unnecessarily 
slow just because of rebuilding the theme every single time.

This change makes the current theme globally cached and will only reload the 
theme when KEmoticons::currentThemeName() returns different value.


Diffs
-----

  src/integrationplugin/ktexttohtml.cpp 3392ccc 

Diff: https://git.reviewboard.kde.org/r/123791/diff/


Testing
-------

Switching between emails in KMail is faster now (even more noticable when the 
system is under load). 
Switched to another emoticon theme in System Settings, then opened another 
email in KMail and it correctly used the new theme.


Thanks,

Daniel Vrátil

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to