----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123706/#review80202 -----------------------------------------------------------
Ship it! src/kmainwindow.cpp (line 154) <https://git.reviewboard.kde.org/r/123706/#comment55027> To be extra safe (not deleting a global file in case saving goes wrong), and faster (checking only one file on disk), this could be QString localFilePath = QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + '/' + config->name(); if (QFile::exists(localFilePath)) { ... } - David Faure On May 11, 2015, 7:52 a.m., Stefan Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123706/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 7:52 a.m.) > > > Review request for KDE Frameworks and Rex Dieter. > > > Bugs: 346768 > https://bugs.kde.org/show_bug.cgi?id=346768 > > > Repository: kxmlgui > > > Description > ------- > > - replace the KConfig object in KConfigGui with a new one using the > session id and key from the QSessionManager object > - make sure that the data is stored after the application has update it > - if the KConfig object is represented by a local file then add a > discard command to the session manager object > > BUG: 346768 > REVIEW: 123706 > > > Diffs > ----- > > src/kmainwindow.cpp 15eecb7 > > Diff: https://git.reviewboard.kde.org/r/123706/diff/ > > > Testing > ------- > > On F22 with kwrite & konsole > > > Thanks, > > Stefan Becker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
