> On mai 2, 2015, 8:50 matin, David Faure wrote: > > autotests/kdelibs4configmigratortest.cpp, line 85 > > <https://git.reviewboard.kde.org/r/123588/diff/1/?file=365397#file365397line85> > > > > The copy that happens above is for creating the KDE4 test files, right? > > > > My QCOMPARE is to ensure that the KF5 file doesn't exist yet. I'm just > > reusing that foreach loop, really. > > > > The point is to then check the same after migrate() and see that the > > KF5 file was created. > > > > I can repeat the foreach() if you think it's more readable.
Oh you're right. Ok I didn't see that it was the code which created kde4 file . So all is good indeed. - Laurent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/#review79776 ----------------------------------------------------------- On mai 2, 2015, 8:17 matin, David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123588/ > ----------------------------------------------------------- > > (Updated mai 2, 2015, 8:17 matin) > > > Review request for KDE Frameworks and Laurent Montel. > > > Repository: kcoreaddons > > > Description > ------- > > Port kdelibs4configmigratortest to QStandardPaths, so it works on other > platforms than XDG. > > > Diffs > ----- > > autotests/kdelibs4configmigratortest.cpp > 0affd2a6bc86f8e4cad04dd662e1298d34b1e7c1 > > Diff: https://git.reviewboard.kde.org/r/123588/diff/ > > > Testing > ------- > > Still passes on Linux, we'll see if the CI says it fixed it for Mac. > > Failure before the fix: > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=OSX,compiler=clang/17/testReport/junit/%28root%29/TestSuite/kdelibs4configmigratortest/ > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
