----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123590/#review79777 -----------------------------------------------------------
Ship it! Indeed, bad porting from ::rename() in 4cf434b4e892. - David Faure On May 2, 2015, 8:38 a.m., Boris Egorov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123590/ > ----------------------------------------------------------- > > (Updated May 2, 2015, 8:38 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 343329 > https://bugs.kde.org/show_bug.cgi?id=343329 > > > Repository: kio > > > Description > ------- > > QFile::rename returns true on success[1], so code should treat it > appropriately. Previously code shows an error when all worked fine. > > 1: http://doc.qt.io/qt-5/qfile.html#rename > > > Diffs > ----- > > src/ioslaves/ftp/ftp.cpp 7036f22 > > Diff: https://git.reviewboard.kde.org/r/123590/diff/ > > > Testing > ------- > > Tested with kioexec and Kate. > > kioexec cat ftp://ftp.gnu.org/welcome.msg > kate ftp://ftp.gnu.org/welcome.msg > > File from ftp loads and showed successfully. > > > Thanks, > > Boris Egorov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
