> On abr. 19, 2015, 4:27 a.m., Simeon Bird wrote: > > Hi everyone, > > > > Sorry to bother you, but may I please commit this? It's been a while. The > > kdelibs version had some positive reviews. > > > > Thanks, > > Simeon > > Albert Astals Cid wrote: > Any reason why we should not fix this in kdelibs too? > > Simeon Bird wrote: > Not at all, the patch applies fairly cleanly. I just didn't realise there > were going to be more releases of kdelibs.
Do you read the emails i send to kde-cvs-annou...@kde.org ? I think i've been clearly direct in stating that we're having LTS releases of kdelibs(KDE/4.14), kdepim(KDE/4.14), kdepimlibs(KDE/4.14), kdepim- runtime(KDE/4.14) and kde-workspace (KDE/4.11) but since you did not know it, i guess i've failed there. Could you please tell me what can i do to improve it so you would know we are still dooing kdelibs releases? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121599/#review79194 ----------------------------------------------------------- On feb. 28, 2015, 10:49 p.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121599/ > ----------------------------------------------------------- > > (Updated feb. 28, 2015, 10:49 p.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure. > > > Repository: kio > > > Description > ------- > > Fix crash in KIO due to exposing inconsistent views of internal data. > > This can be triggered by renaming a directory while one of the files in it is > open in gwenview. > > It occurs because when KDirListerCache::emitRedirections is called, > itemsInUse contains the old url. However, KDirLister::Private::redirect > changes lstDirs to the new url. Thus at this point lstDirs contains an > item not in itemsInUse, which causes an assertion if forgetDirs is > called. > > In gwenview, the redirection signal is connected to openURL. This calls > forgetDirs, and causes the assertion. > > The solution: update itemsInUse *before* emitting redirections. > > This fixes the crash, but gwenview opens the first file in > the new directory instead of the file open before renaming. > This is probably an unrelated gwenview bug. > > This is the same as reviewboard 117345, but on the KF5 kio repository and > with a test case. > > While I was doing this I also fixed a minor bug in the test suite (which is a > separate commit). > > > Diffs > ----- > > autotests/kdirlistertest.h 70fd16f > autotests/kdirlistertest.cpp b588e5b > src/core/kcoredirlister.cpp f5c5627 > > Diff: https://git.reviewboard.kde.org/r/121599/diff/ > > > Testing > ------- > > Tests run > > > Thanks, > > Simeon Bird > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
