----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123348/#review79132 -----------------------------------------------------------
This breaks the build of plasma-workspace ``` [ 413s] In file included from /usr/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1:0, [ 413s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.3.91git~20150418T140715~73ee8a0/dataengines/geolocation/location_ip.cpp:31: [ 413s] /usr/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:26:37: fatal error: networkmanagerqt_export.h: No such file or directory [ 413s] #include <networkmanagerqt_export.h> [ 413s] ^ ``` The headers include <networkmanagerqt_export.h>, which is now in lowercase directory, and is not in public INTERFACE includes... - Hrvoje Senjan On April 17, 2015, 2:10 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123348/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 2:10 p.m.) > > > Review request for KDE Frameworks and Jan Grulich. > > > Repository: networkmanager-qt > > > Description > ------- > > The examples didn't build because <NetworkManagerQt/Manager> didn't exist > locally in the builddir. Using ecm_generate_headers properly for such a > namespaced > framework (i.e. with PREFIX, like KParts does) fixes that, and makes the > installation > of the headers more standard: > NetworkManagerQt/Manager and networkmanagerqt/manager.h, all lowercase; > both only available if linking to KF5::NetworkManagerQt. > > This will break users of <NetworkManagerQt/manager.h> though > (camelcase/lowercase mix), > if there are any. > > > Diffs > ----- > > src/CMakeLists.txt d59949bd2264b1e10de3bc4fedb9e50b8c88f1f3 > > Diff: https://git.reviewboard.kde.org/r/123348/diff/ > > > Testing > ------- > > Compiled examples, ran make install and checked destination paths, rebuilt > plasma-nm succesfully. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
