----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123329/#review78883 -----------------------------------------------------------
Ship it! src/notifybytaskbar.cpp (line 45) <https://git.reviewboard.kde.org/r/123329/#comment53937> That should perhaps be a qWarning? - Martin Klapetek On April 13, 2015, 11:10 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123329/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 11:10 a.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > Don't crash if notification has no widget and notification is set to notify > by taskbar > > > Diffs > ----- > > src/notifybytaskbar.cpp 72d01af > > Diff: https://git.reviewboard.kde.org/r/123329/diff/ > > > Testing > ------- > > Builds > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
