----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123349/ -----------------------------------------------------------
Review request for KDE Frameworks and Jan Grulich. Repository: networkmanager-qt Description ------- This is built as part of the framework, so it should not do find_package on itself, it won't work the first time. I assume this was there in order to all build separately, so I left it commented out, but it's wrong to have that in. Maybe with the last two commits, the examples can be built by default, like in the other frameworks, so that we ensure that they always do build? Diffs ----- examples/CMakeLists.txt c2484b346b70596ddeb87778c7dd3881851441fb Diff: https://git.reviewboard.kde.org/r/123349/diff/ Testing ------- rebuilt the examples from scratch, worked Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
