----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/#review77901 -----------------------------------------------------------
I doubt the test will work on the CI system as there we don't have a KWin which run and registered the shortcut. It's basically an empty config. It would be better to use one of the two actions used by the test. src/kglobalaccel.h (line 266) <https://git.reviewboard.kde.org/r/122981/#comment53408> can I get your time machine? https://www.kde.org/announcements/kde-frameworks-5.8.0.php ;-) - Martin Gräßlin On March 21, 2015, 1:39 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122981/ > ----------------------------------------------------------- > > (Updated March 21, 2015, 1:39 p.m.) > > > Review request for KDE Frameworks, Martin Gräßlin and Thomas Lübking. > > > Repository: kglobalaccel > > > Description > ------- > > In some cases you need to call loadShortcutFromGlobalSettings() in order not > to get a an empty list when calling shortcut(). See discussion in > https://git.reviewboard.kde.org/r/122249/. > > > Diffs > ----- > > autotests/kglobalshortcuttest.h 2a7b40d34875e16345a659fb9764e4f536ad79c6 > autotests/kglobalshortcuttest.cpp 169bf92ffbff985cd4381e771c2fcecaff77156b > src/kglobalaccel.h 3fe20ca8e4ec6ceb0bb9e54235aef7f1aeeb8c16 > src/kglobalaccel.cpp 1b6b3f5cb6d42401d684e6a491d12a6e57248fd1 > > Diff: https://git.reviewboard.kde.org/r/122981/diff/ > > > Testing > ------- > > > Thanks, > > Gregor Mi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
