----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77276 -----------------------------------------------------------
> I don't know whether this is binary compatible. It is not. A class compiled against the old KIconDialog sees no reimplementation for the showEvent method, and thus calls the parent's showEvent. Please try an event filter if this needs to be fixed. - Christoph Feck On March 10, 2015, 7:32 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122893/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 7:32 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kiconthemes > > > Description > ------- > > Populate the dialog on showEvent, this way you can use the regular QDialog > show() and exec() methods and use, for instance, Qt::WindowModal rather than > having showDialog() or openDialog() mess with modality. showDialog() could > probably be deprecated then. > > I don't know whether this is binary compatible. "you can safely reimplement a > virtual function defined in one of the base classes only if it is safe that > the programs linked with the prior version call the implementation in the > base class rather than the derived one" > > > Diffs > ----- > > src/kicondialog.h ee4edca > src/kicondialog.cpp 7a6c1f1 > > Diff: https://git.reviewboard.kde.org/r/122893/diff/ > > > Testing > ------- > > Just calling show() on the KIconDialog works as expected, the icon button in > kfileproperties thingie dialog still works. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
