> On March 1, 2015, 2:34 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me, can you push yourself?
I can push it myself if someone decides whether that static_cast<int>(KJob::NoError) is fine or if 0 should be hardcoded (like in my first patch). I am fine with both - so I'd like to stick to what the "KDE way" is :) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review76790 ----------------------------------------------------------- On March 1, 2015, 12:21 p.m., Martin Blumenstingl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122755/ > ----------------------------------------------------------- > > (Updated March 1, 2015, 12:21 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > This adds some automated testcases for KIO::del(). > > My own code was buggy but I didn't notice this until I wrote those tests. > Maybe you want to have them upstream to make sure noone breaks KIO::del. > > > Diffs > ----- > > autotests/deletejobtest.cpp PRE-CREATION > autotests/CMakeLists.txt f613c1a > autotests/deletejobtest.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122755/diff/ > > > Testing > ------- > > Tests are passing > > > Thanks, > > Martin Blumenstingl > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
