----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122754/#review76794 -----------------------------------------------------------
Ship it! Checked also that _ki18n_pmap_compile_script still works. - Chusslove Illich On Феб. 28, 2015, 2:52 по п., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122754/ > ----------------------------------------------------------- > > (Updated Феб. 28, 2015, 2:52 по п.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > This variable (and the corresponding if/else in KF5I18NMacros) is > unnecessary, as the scripts needed by KF5I18NMacros.cmake are always in > the same directory as KF5I18NMacros.cmake. > > We keep the variable, albeit set in a simpler way, in case anything else > is using it (by the CMake naming convention, a variable with no leading > underscore is public). > > > Diffs > ----- > > KF5I18nConfig.cmake.in 64dc5009e4821f9e1bb3631c596b56e66c578c3c > cmake/KF5I18NMacros.cmake a55f472bdfdebd2e353064f102c1f1372fdf0918 > > Diff: https://git.reviewboard.kde.org/r/122754/diff/ > > > Testing > ------- > > Built, run `make test`. Built and installed ktexteditor (uses ki18n_wrap_ui). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
