-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122459/
-----------------------------------------------------------
Review request for KDE Frameworks.
Bugs: 343735
https://bugs.kde.org/show_bug.cgi?id=343735
Repository: kio
Description
-------
This is an attempt to fix a bug that seems quite difficult to reproduce, but
definitely happens
It seems there is a weird race condition linked to the sync of the two files
.local/share/user-places.xbel
.local/share/kfileplaces/bookmarks.xml
causing the bug
https://bugs.kde.org/show_bug.cgi?id=343735
all processes that are listening for changes in the bookmark manager will try
to sync their bookmarks with the shared ones (user-places.xbel) and depending
what process arrives first, some bookmarks may be lost
if this is ok, it will have to go in kdelibs4 (since distributions will support
kde4 apps for a long time still)
as well as (ouch) dolphin both 4 and 5, since it forks KFilePlacesModel
Diffs
-----
src/filewidgets/kfileplacesmodel.cpp d8da868
src/filewidgets/kfileplacessharedbookmarks.cpp fbd6b53
src/filewidgets/kfileplacessharedbookmarks_p.h 4c9f6a4
Diff: https://git.reviewboard.kde.org/r/122459/diff/
Testing
-------
Thanks,
Marco Martin
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
