----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122438/#review75461 -----------------------------------------------------------
src/knotificationplugin.h <https://git.reviewboard.kde.org/r/122438/#comment52186> Why wait? You can do that now and deprecate this function, right? You just can't remove it till KF6. Same for the other TODO lines you added. - Mark Gaiser On feb 5, 2015, 9:43 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122438/ > ----------------------------------------------------------- > > (Updated feb 5, 2015, 9:43 a.m.) > > > Review request for KDE Frameworks and Martin Klapetek. > > > Repository: knotifications > > > Description > ------- > > Similar to review 122396. > > Well... though knotifyconfig is not installed but ABI checker seems not happy > with it. So let's just use the crappy knotifyconfig for now. > > > Diffs > ----- > > src/notifybytaskbar.cpp b52e180 > src/knotificationmanager.cpp 3cf637c > src/knotificationplugin.h 3438e7d > src/notifybypopup.h a605a77 > src/notifybypopup.cpp 2f08146 > src/CMakeLists.txt 3e5821a > > Diff: https://git.reviewboard.kde.org/r/122438/diff/ > > > Testing > ------- > > works. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
