> On Jan. 23, 2015, 9:58 p.m., David Faure wrote: > > Not sure why this is suddenly triggering many philosophical discussions > > about what users should be doing (IMHO, give them choice, this is > > opensource). > > Similar changes have been done in most other frameworks long ago, this is > > most certainly consistent. > > (see e.g. kcoreaddons - the find_package(Qt5Test) is being done in the > > autotests subfolder, the same could be done here). > > Vishesh Handa wrote: > It's not about users, it's about developers/packagers. We're not forcing > them to run the tests, we're telling them to compile them. They always have a > choice by modifying the code, we as upstream shouldn't be making it easier > for them to skip the most of basic of quality tests. > > Martin Gräßlin wrote: > @Vishesh: as I went through the same thing I point you to > https://git.reviewboard.kde.org/r/117393/ - it was a discussion for the same > on KWin and now I think it was good that we accepted the solution in the end. > Maybe the reasoning provided there helps to understand the packagers needs. > > Vishesh Handa wrote: > @Martin: I do prefer the solution in the kwin patch. This one is really > messy. > > Though I still don't agree with their reasons. > > Andreas Sturmlechner wrote: > @David, I should add that I can not commit this myself, without write > access, so I ask for someone to do it. Unless I should come up with a > solution similar to Martin's, so more people could agree?
@Andreas: I think the solution in KWin is better and more straight forward for both packagers and developers. So I recommend to change to such an approach. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122206/#review74633 ----------------------------------------------------------- On Jan. 22, 2015, 8:48 p.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122206/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 8:48 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > [kio] Make tests optional > This is a small patch to CMakeLists.txt to only depend on Qt5Test if > BUILD_TESTING. > > > Diffs > ----- > > CMakeLists.txt 7fe0be5d4b2d7d9475a7844b4f8d93fc2f0a00c3 > > Diff: https://git.reviewboard.kde.org/r/122206/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sturmlechner > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
