----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121838/#review73314 -----------------------------------------------------------
Ship it! Thanks, LGTM. If possible, could you please split the unit test refactoring out to a separate commit just before the bug fix commit? If not, just push it as is. - Matthew Dawson On Jan. 6, 2015, 5:41 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121838/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 5:41 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > We need to refresh mLoadedValue after a save, otherwise the value is stale. > > I'm doing this by resetting mLoadedValue to mReference in all the > ::writeConfig. > > I've also refactored the tests so they can be run independently now just fine. > > > Diffs > ----- > > autotests/kconfigskeletontest.cpp f401b9f > src/core/kcoreconfigskeleton.h f8313d1 > src/core/kcoreconfigskeleton.cpp e4255a6 > CMakeLists.txt 205c38b > autotests/kconfigskeletontest.h c54c7b0 > > Diff: https://git.reviewboard.kde.org/r/121838/diff/ > > > Testing > ------- > > My tests now pass. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
