----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121786/ -----------------------------------------------------------
(Updated Jan. 2, 2015, 12:27 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Repository: knotifications Description ------- sendNotificationToGalagoServer creates a new QDBusPendingCallWatcher for a sent DBus message. It puts a pointer to the KNotification as a property on the QObject. If the local KNotification object got destroyed whilst that DBus operation was happening this meant we would read a dangling pointer. By setting the parent of the call watcher to the notification we can make sure we don't process the call finishing if the notification no longer exists. BUG: 340845 Diffs ----- src/notifybypopup.cpp 66e593b Diff: https://git.reviewboard.kde.org/r/121786/diff/ Testing ------- Triggered a notification. It all still worked. Thanks, David Edmundson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
