----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/ -----------------------------------------------------------
Review request for KDE Frameworks, Lukáš Tinkl, Mark Gaiser, and Martin Klapetek. Repository: frameworkintegration Description ------- Commit 0b8ab82e7fa9ea0948a841ebf8523b62da made the view mode a choice of the user (as it always was in KDE code) rather than a choice of the developer (as QFileDialog::setViewMode allows). Typical Qt/KDE difference: Qt empowers the developer, KDE empowers the user. I agree with Lukas that the latter makes more sense in KDE code. => I rewrote the unittest to check that the user's changes are restored on the next file dialog. Diffs ----- autotests/kfiledialog_unittest.cpp e5108ead5a381864cfa2b8ddf62b5d6c64b13db9 Diff: https://git.reviewboard.kde.org/r/121747/diff/ Testing ------- Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
