> On Dec. 26, 2014, 8:14 a.m., David Faure wrote: > > This has been reverted for now, it broke the kio_trash unittest, because it > > doesn't preserve extensions anymore. Please revisit. > > Arjun AK wrote: > Like i said in the ML, what should be done with the following files: > `.txt` > `..txt` > `...`
With the goal of "preserving extensions", I would say: .txt -> 1.txt ..txt -> 1..txt or .1.txt (don't really care which one) ... -> whatever What the patch broke was much more severe: file.foo became file.foo1 (for any unknown extension). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/#review72518 ----------------------------------------------------------- On Dec. 23, 2014, 5:56 p.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121461/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 5:56 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 341773 > https://bugs.kde.org/show_bug.cgi?id=341773 > > > Repository: kio > > > Description > ------- > > 1.Fix bug 341773 (Replace dialog suggests incorrect filename when it contains > dots). Make use of `QMimeDatabase::suffixForFileName` for calculating the > extension. > 2. Rename `.foo` and `..foo` into `.foo 1` and `..foo 1` respectively, > instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't > be changing that. > > > Diffs > ----- > > autotests/globaltest.cpp 06cb500 > src/core/global.cpp f18ac10 > > Diff: https://git.reviewboard.kde.org/r/121461/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
