----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/#review72258 -----------------------------------------------------------
In general +1 to the idea. I think it makes more sense to have stuff availalbe to all applications. I still have coments on the review you have open in gerrit which I don't want to copy & paste here and end up with fragmented reviews. src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.cpp <https://git.reviewboard.kde.org/r/121581/#comment50399> Either I was very drunk, or this is a lie. - David Edmundson On Dec. 17, 2014, 4:20 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121581/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 4:20 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This is an alternative, mutually exclusive to > https://gerrit.vesnicky.cesnet.cz/r/#/c/244 > and dependent from > https://git.reviewboard.kde.org/r/121575/ > > since the plotter component doesn't depend from libplasma, it may be useful > to have it outside of libplasma, so any applciation that wants it may use it. > Any opinion whether this should go here or in libplasma is welcome. > > > Diffs > ----- > > CMakeLists.txt 233ccce > src/qmlcontrols/kquickcontrols/CMakeLists.txt eef0420 > src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.h PRE-CREATION > src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.cpp PRE-CREATION > src/qmlcontrols/kquickcontrols/plotter.h PRE-CREATION > src/qmlcontrols/kquickcontrols/plotter.cpp PRE-CREATION > src/qmlcontrols/kquickcontrols/qmldir 31d8b14 > > Diff: https://git.reviewboard.kde.org/r/121581/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
