----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 -----------------------------------------------------------
For frameworks version it's actually using notifybyaudio plugin for playing the sounds and that's using phonon exclusively, there's no more volume fiddling in fact. The notifybysound should just be removed altogether..don't know why it's still around :O - Martin Klapetek On Dec. 4, 2014, 10:12 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121356/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 10:12 p.m.) > > > Review request for KDE Frameworks and David Edmundson. > > > Repository: knotifications > > > Description > ------- > > Playing a notification should be that, playing a notification. > > Inspired by David's comment on https://git.reviewboard.kde.org/r/121278/ > > > Diffs > ----- > > src/notifybysound.cpp 09a80dd > > Diff: https://git.reviewboard.kde.org/r/121356/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
