> On Dec. 4, 2014, 8:42 a.m., David Faure wrote: > > src/lib/util/kdelibs4migration.cpp, line 52 > > <https://git.reviewboard.kde.org/r/121303/diff/1/?file=331217#file331217line52> > > > > These 3 lines could be removed then - if KDE4_DEFAULT_HOME doesn't > > exist, there isn't much point in pointing to it. > > > > But ok it doesn't change anything in practice, kdeHomeFound() tests for > > exists anyway. > > Xuetian Weng wrote: > Emm. but the reason that KDE4_DEFAULT_HOME being introduced: > https://git.reviewboard.kde.org/r/120480/diff/ is that it would be better to > leave it non-empty. (in case user install some kde4 app later).
Ah, hmm, ok. Won't work if KDE4_DEFAULT_HOME isn't set, though. But then it's hard to guess what kdehome should point to, if nothing exists yet. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121303/#review71323 ----------------------------------------------------------- On Dec. 4, 2014, 9:07 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121303/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 9:07 a.m.) > > > Review request for KDE Frameworks, David Faure and Laurent Montel. > > > Repository: kcoreaddons > > > Description > ------- > > some really old distribution might use ~/.kde for kde3 and ~/.kde4 for kde4, > and in some other case ~/.kde might be existed for random reason. > > This change will change the check order to KDE4_DEFAULT_HOME (from cmake > option), .kde4, .kde. So distro can always specify their correct one as the > first one. And check ~/.kde4 before ~/.kde seems to be a saner option because > they must use "4" for a good reason. > > > Diffs > ----- > > src/lib/util/kdelibs4migration.cpp d8d564a > > Diff: https://git.reviewboard.kde.org/r/121303/diff/ > > > Testing > ------- > > return ~/.kde4 first even ~/.kde exists. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
