----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121313/#review71195 -----------------------------------------------------------
Ship it! Suggesting metaDataFile(), otherwise looks good. src/lib/plugin/kpluginmetadata.h <https://git.reviewboard.kde.org/r/121313/#comment49737> metaDataFileName() would be more synchronous with the matching ctor and the fileName() accessor - Sebastian Kügler On Dec. 1, 2014, 3:59 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121313/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 3:59 p.m.) > > > Review request for KDE Frameworks, David Faure and Sebastian Kügler. > > > Repository: kcoreaddons > > > Description > ------- > > When creating a KPluginMetaData object from a .desktop file we currently > set fileName() to point to the .desktop file. However, passing > fileName() to KPluginLoader should allow loading the plugin. To fix this > we store the value of the X-KDE-Library key as fileName() instead and > move the path to the .desktop file to a new property metaDataSource() > > > Diffs > ----- > > autotests/kpluginmetadatatest.cpp 0a10ed05f48d38b7455ef6fa4248b4c46090c6d8 > src/lib/plugin/desktopfileparser.h 312d1c7b8070000f949eec0f1e41616845b92afd > src/lib/plugin/desktopfileparser.cpp > 1dcc1a02e3fd023387d1b8b03884ae069ba96a1b > src/lib/plugin/kpluginmetadata.h 5b1ead5cf2b508754927b72d71c44aca58919ec4 > src/lib/plugin/kpluginmetadata.cpp 3100a4cf6bb24de322a70401c0b66c710727610e > > Diff: https://git.reviewboard.kde.org/r/121313/diff/ > > > Testing > ------- > > unit test passes > > Not sure if `metaDataSource()` is a good name, after all the class is already > called KPluginMetaData. Maybe just `source()`? > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
