----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121230/#review71164 -----------------------------------------------------------
Ship it! Ship It! - David Faure On Nov. 24, 2014, 5:52 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121230/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 5:52 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > The code was hard disabled due to usage of Q_WS_X11. The task is > to get the startupid passed to kioexec and forward it to the > process started by kioexec. As Qt's xcb plugin removes the > DESKTOP_STARTUP_ID environment variable once it is read, this needs > special handling to setup the enivornment for the process to be > started. > > Unfortunately the fix requires Qt 5.4 as the startupId is only > provided by QX11Extras since 5.4. > > > Diffs > ----- > > CMakeLists.txt 888edff2bee476b4d2098b375a38a2b3a86135e8 > src/kioexec/CMakeLists.txt 6c587e19310a5395f0db455f48fe18a27e9ec386 > src/kioexec/config-kioexec.h.cmake PRE-CREATION > src/kioexec/main.cpp f0e282394c4f65df0bf52141290d37ba6b32ad8c > > Diff: https://git.reviewboard.kde.org/r/121230/diff/ > > > Testing > ------- > > used > DESKTOP_STARTUP_ID="FOO" kioexec "gwenview %U" file:///path/to/local/file.png > > with and without the change and inspected /proc/x/environ for the started > gwenview process. Without the patch DESKTOP_STARTUP_ID is not set, with the > patch it's properly set to "FOO" in this case. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
