----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121175/#review70816 -----------------------------------------------------------
Problem: I don't think anyone looking for this functionality would think of looking in KCodecs. This is not related to codecs at all. kcoreaddons/src/lib/text/ has more similar stuff, like KStringHandler::tagUrls. Thinking about it, we could have renamed KCodecs to KStringUtils and moved the kcoreaddons text subdir there, but it's too late for that. So my suggestion would be to add KEmailAddress to kcoreaddons/src/lib/text. - David Faure On Nov. 19, 2014, 1:23 p.m., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121175/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 1:23 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kcodecs > > > Description > ------- > > This class can be very useful to many applications that need to deal with > email > address validation, and so it should not be hidden somewhere in PIM, but > should be available in some more visibile framework. Also I need to kill the > KPimUtils framework, and we don't really have any better-fitting framework > available at this moment :) > > > Diffs > ----- > > autotests/CMakeLists.txt 825e9e8 > autotests/kemailaddresstest.h PRE-CREATION > autotests/kemailaddresstest.cpp PRE-CREATION > src/CMakeLists.txt 8b5c4a0 > src/kemailaddress.h PRE-CREATION > src/kemailaddress.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121175/diff/ > > > Testing > ------- > > Test passes. > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
