----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/ -----------------------------------------------------------
(Updated Nov. 18, 2014, 2:38 p.m.) Status ------ This change has been discarded. Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description ------- KIconLoader (and KIconTheme) were always using single int to specify icon size, which implies only square icons. When requesting non-square icons however (such as pixmap sequence animations), the returned QPixmap is deformed. This patch ports all internals of KIconLoader to QSize. Diffs ----- src/kiconengine.cpp 530403e src/kiconloader.h 46d3017 src/kiconloader.cpp 2587b46 src/kicontheme.h ca04879 src/kicontheme.cpp 4f0e522 Diff: https://git.reviewboard.kde.org/r/120155/diff/ Testing ------- QIcon icon = QIcon::fromTheme(QLatin1String("process-working")); QPixmap pix = icon.pixmap(22, 8 * 22); With this patch, the pix looks as expected. Thanks, Daniel Vrátil
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
